flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3198: [FLINK-5626] Improved resource deallocation in Roc...
Date Tue, 24 Jan 2017 11:10:49 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
    @@ -148,16 +140,14 @@ public RocksDBKeyedStateBackend(
     	) throws Exception {
     		super(kvStateRegistry, keySerializer, userCodeClassLoader, numberOfKeyGroups, keyGroupRange);
    -		this.operatorIdentifier = operatorIdentifier;
    -		this.jobId = jobId;
     		this.columnOptions = columnFamilyOptions;
     		this.instanceBasePath = instanceBasePath;
     		this.instanceRocksDBPath = new File(instanceBasePath, "db");
    --- End diff --
    Maybe we could add here `Preconditions` checks?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message