flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #3026: [FLINK-2980] [table] Support for GROUPING SETS cla...
Date Mon, 23 Jan 2017 14:13:14 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3026#discussion_r97320762
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
    @@ -94,7 +94,24 @@ case class Project(projectList: Seq[NamedExpression], child: LogicalNode)
extend
       override protected[logical] def construct(relBuilder: RelBuilder): RelBuilder = {
         child.construct(relBuilder)
         relBuilder.project(
    -      projectList.map(_.toRexNode(relBuilder)).asJava,
    +      projectList.map {
    --- End diff --
    
    I think this translation should rather happen in `resolveExpression` and needs to be reworked
a bit. E.g. `groupId() as 'a as 'f` fails. Some inline comments would also be very good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message