flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #3128: [FLINK-5464] Improve MetricDumpSerialization error...
Date Mon, 23 Jan 2017 13:47:54 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3128#discussion_r97314949
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
    @@ -50,12 +51,27 @@
     	private MetricDumpSerialization() {
     	}
     
    +	public static class MetricSerializationResult {
    --- End diff --
    
    Can you add a short class level comment about why we added this? The problem with determining
number of metrics before hand etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message