flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #3128: [FLINK-5464] Improve MetricDumpSerialization error...
Date Mon, 23 Jan 2017 13:47:54 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3128#discussion_r97316854
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDumpSerialization.java
---
    @@ -191,62 +233,65 @@ private static void serializeMeter(DataOutputStream dos, Meter meter)
throws IOE
     		 *
     		 * @param data serialized metrics
     		 * @return A list containing the deserialized metrics.
    -		 * @throws IOException
     		 */
    -		public List<MetricDump> deserialize(byte[] data) throws IOException {
    -			ByteArrayInputStream bais = new ByteArrayInputStream(data);
    -			DataInputStream dis = new DataInputStream(bais);
     
    -			int numCounters = dis.readInt();
    -			int numGauges = dis.readInt();
    -			int numHistograms = dis.readInt();
    -			int numMeters = dis.readInt();
    +		public List<MetricDump> deserialize(MetricDumpSerialization.MetricSerializationResult
data) {
    --- End diff --
    
    In line 230, an empty line is missing before `class MetricDumpDeserializer`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message