flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2866: [FLINK-5101] Refactor CassandraConnectorITCase
Date Mon, 23 Jan 2017 12:50:20 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2866#discussion_r97309712
  
    --- Diff: flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
    @@ -94,5 +122,9 @@ public void close() {
     		} catch (Exception e) {
     			LOG.error("Error while closing cluster.", e);
     		}
    +		Throwable e = exception.get();
    +		if (e != null) {
    +			LOG.error("Error while sending value.", e);
    --- End diff --
    
    This needs to be rethrown, otherwise close() may complete without an exception, but the
result may be incomplete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message