flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #3178: [FLINK-5214] Clean up checkpoint data in case of a...
Date Mon, 23 Jan 2017 09:57:20 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3178#discussion_r97279484
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateSnapshotContextSynchronousImpl.java
---
    @@ -127,4 +128,38 @@ public OperatorStateCheckpointOutputStream getRawOperatorStateOutput()
throws Ex
     		return new DoneFuture<>(stream.closeAndGetHandle());
     	}
     
    -}
    \ No newline at end of file
    +	private <T extends StreamStateHandle> void closeAndUnregisterStream(NonClosingCheckpointOutputStream<T>
stream) throws IOException {
    +		Preconditions.checkNotNull(stream);
    +
    +		closableRegistry.unregisterClosable(stream.getDelegate());
    +		stream.getDelegate().close();
    +	}
    +
    +	public void close() throws IOException {
    --- End diff --
    
    If we already introduce a close method, we could also make this implement `AutoCloseable`
and use it in try-with-resource?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message