flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2974: [FLINK-5298] TM checks that log file exists
Date Thu, 19 Jan 2017 11:47:03 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2974#discussion_r96843696
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
    @@ -821,7 +821,7 @@ class TaskManager(
         val logFilePathOption = Option(config.configuration.getString(
           ConfigConstants.TASK_MANAGER_LOG_PATH_KEY, System.getProperty("log.file")));
         logFilePathOption match {
    -      case None => throw new IOException("TaskManager log files are unavailable. "
+
    +      case None => sender ! new IOException("TaskManager log files are unavailable.
" +
    --- End diff --
    
    In order to send an `Exception` over the wire to the sender it has to be packed into `akka.actor.Status.Failure`.
Otherwise it will only be sent as a normal response type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message