flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ex00 <...@git.apache.org>
Subject [GitHub] flink pull request #3033: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...
Date Wed, 18 Jan 2017 08:29:34 GMT
Github user ex00 commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala
    @@ -46,6 +47,7 @@ class DataSetSingleRowJoin(
         rowRelDataType: RelDataType,
         joinCondition: RexNode,
         joinRowType: RelDataType,
    +    joinType: JoinRelType,
    --- End diff --
    Good point, but maybe add additional check in other method? for example in `translateToPlan`.

    In this case if ``DataSetSingleRowJoin.computeSelfCost`` don't return best cost we don't
get exception and don't select incorrect ``RelNode``. but if we whatever get best cost we
can throw exception in  `translateToPlan` for incorrect joinType.
    What do you mean about it?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message