flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KurtYoung <...@git.apache.org>
Subject [GitHub] flink pull request #3111: [FLINK-3475] [Table] DISTINCT aggregate function s...
Date Tue, 17 Jan 2017 01:23:25 GMT
Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3111#discussion_r96329552
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala
---
    @@ -96,6 +96,13 @@ object FlinkRuleSets {
         ProjectToCalcRule.INSTANCE,
         CalcMergeRule.INSTANCE,
     
    +    // distinct aggregate rule for FLINK-3475
    --- End diff --
    
    I think this comment can move to `FlinkAggregateExpandDistinctAggregatesRule`, and open
a jira to track to remove this class after we upgrade Calcite.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message