flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #3090: [FLINK-5432] Fix nested files enumeration in Conti...
Date Thu, 12 Jan 2017 12:38:21 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3090#discussion_r95782207
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
    @@ -282,7 +282,7 @@ private void monitorDirAndForwardSplits(FileSystem fs,
     	 * Returns the paths of the files not yet processed.
     	 * @param fileSystem The filesystem where the monitored directory resides.
     	 */
    -	private Map<Path, FileStatus> listEligibleFiles(FileSystem fileSystem) throws
IOException {
    +	private Map<Path, FileStatus> listEligibleFiles(FileSystem fileSystem, String
path) throws IOException {
    --- End diff --
    
    I would suggest passing a `Path` here. It is always a safer option to rely on the this
class than on strings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message