flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KurtYoung <...@git.apache.org>
Subject [GitHub] flink pull request #3073: [FLINK-5418] [table] Estimated row size does not s...
Date Tue, 10 Jan 2017 19:25:42 GMT
Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3073#discussion_r95437867
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/FlinkRel.scala
---
    @@ -120,6 +120,7 @@ trait FlinkRel {
             case typeName if SqlTypeName.YEAR_INTERVAL_TYPES.contains(typeName) => s +
8
             case typeName if SqlTypeName.DAY_INTERVAL_TYPES.contains(typeName) => s +
4
             case SqlTypeName.TIME | SqlTypeName.TIMESTAMP | SqlTypeName.DATE => s + 12
    +        case SqlTypeName.ARRAY | SqlTypeName.ROW | SqlTypeName.ANY => s + 24
    --- End diff --
    
    Any chance we can expand the ARRAY or the ROW type, and only counting the basic data structures
to make this a little more accurate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message