flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaelumania <...@git.apache.org>
Subject [GitHub] flink issue #3086: Improve docker setup
Date Tue, 10 Jan 2017 18:03:52 GMT
Github user kaelumania commented on the issue:

    https://github.com/apache/flink/pull/3086
  
    @mxn One drawback using `ENV` might be with docker-compose, see https://docs.docker.com/compose/compose-file/#/args
which states
    
    > You can omit the value when specifying a build argument, in which case its value
at build time is the value in the environment where Compose is running.
    
    > Note: If your service specifies a build option, variables defined in environment
will not be automatically visible during the build. Use the args sub-option of build to define
build-time environment variables.
    
    On the other hand the Dockerfile reference says (https://docs.docker.com/engine/reference/builder/#/arg)
    
    > Unlike an ARG instruction, ENV values are always persisted in the built image.
    
    Maybe something like this can be used to support both
    ```
    1 FROM ubuntu
    2 ARG CONT_IMG_VER
    3 ENV CONT_IMG_VER ${CONT_IMG_VER:-v1.0.0}
    4 RUN echo $CONT_IMG_VER
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message