flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #2870: [FLINK-4565] Support for SQL IN operator
Date Fri, 06 Jan 2017 10:11:51 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2870#discussion_r94922269
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/expressions/ScalarFunctionsTest.scala
---
    @@ -1101,6 +1101,45 @@ class ScalarFunctionsTest extends ExpressionTestBase {
           "true")
       }
     
    +  @Test
    +  def testInExpressions(): Unit = {
    +    testTableApi(
    --- End diff --
    
    Can you add some more tests? E.g.
    - `Null(Types.INT).in(1,2,42, Null(Types.INT))` cannot be compiled.
    - Date/Time/Timestamp types which are represented as int/long internally.
    - POJOs/Tuples/Case classes
    - Fields in the set `f2.in(f3, f4, 4)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message