flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #2870: [FLINK-4565] Support for SQL IN operator
Date Fri, 06 Jan 2017 10:11:51 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2870#discussion_r94807323
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarOperators.scala
---
    @@ -79,6 +79,72 @@ object ScalarOperators {
         }
       }
     
    +  def generateIn(
    +      nullCheck: Boolean,
    +      left: GeneratedExpression,
    +      right: scala.collection.mutable.Buffer[GeneratedExpression],
    +      addReusableCodeCallback: (String, String) => Any)
    +    : GeneratedExpression = {
    +    val resultTerm = newName("result")
    +    val isNull = newName("isNull")
    +
    +    val topNumericalType: Option[TypeInformation[_]] = {
    --- End diff --
    
    You can extract this logic into a separate method (e.g. in `TypeCheckUtils`). Because
it might be useful at other locations too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message