Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: Fokko <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
Message-ID: <git-pr-3052-flink@git.apache.org>
Subject: [GitHub] flink pull request #3052: Swap the pattern matching order
Content-Type: text/plain
Date: Thu, 29 Dec 2016 22:53:29 +0000 (UTC)
archived-at: Thu, 29 Dec 2016 22:53:33 -0000

GitHub user Fokko opened a pull request:

    https://github.com/apache/flink/pull/3052

    Swap the pattern matching order

    Swap the pattern matching order, because `EuclideanDistanceMetric extends SquaredEuclideanDistanceMetric extends DistanceMetric`, otherwise the EuclideanDistance cannot be executed:
    
    ```
    [WARNING] /Users/fokkodriesprong/Desktop/flink-fokko/flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala:106: warning: unreachable code
    [WARNING]         case _: EuclideanDistanceMetric => math.sqrt(minDist)
    [WARNING]                                                     ^
    [WARNING] warning: Class org.apache.log4j.Level not found - continuing with a stub.
    [WARNING] warning: there were 1 feature warning(s); re-run with -feature for details
    [WARNING] three warnings found
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Fokko/flink fd-fix-pattern-matching

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3052.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3052
    
----
commit 29ebffc77cfbe917796f44764936972b578ebd38
Author: Fokko Driesprong <fokkodriesprong@godatadriven.com>
Date:   2016-12-29T22:49:14Z

    Swap the pattern matching order, because EuclideanDistanceMetric extends SquaredEuclideanDistanceMetric extends DistanceMetric, otherwise the EuclideanDistance cannot be executed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---