Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 19 Dec 2016 20:31:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13029185.1482165619000.556940.1482179518348@Atlassian.JIRA>
In-Reply-To: <JIRA.13029185.1482165619000@Atlassian.JIRA>
References: <JIRA.13029185.1482165619000@Atlassian.JIRA> <JIRA.13029185.1482165619041@arcas>
Subject: [jira] [Commented] (FLINK-5369) Rework jsr305 and logging
 dependencies
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 19 Dec 2016 20:32:00 -0000


    [ https://issues.apache.org/jira/browse/FLINK-5369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762228#comment-15762228 ] 

ASF GitHub Bot commented on FLINK-5369:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3029
  
    I think this is a quite crucial change for 1.2, because dependency structure cannot be changed in minor releases.
    
    @rmetzger to your attention


> Rework jsr305 and logging dependencies
> --------------------------------------
>
>                 Key: FLINK-5369
>                 URL: https://issues.apache.org/jira/browse/FLINK-5369
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>             Fix For: 1.2.0
>
>
> Currently, every project in Flink has a hard (compile scope) dependency on the {{jsr305}}, {{slf4j}}, {{log4j}}, and {{commons-land3}} artifacts, because these dependencies are declared in the root pom.xml. That way they are pulled into every fat jar, including user fat jars as soon as they refer to a connector or library.
> We should get the {{log4j}} related dependencies out of the root pom file. Ideally these dependencies are only in test scope (as the default logger for testing) and in {{flink-dist}} and the quickstart poms. But to keep compatibility with the current project setups by users, we could also add them to {{flink-core}}.
> In addition, the projects whose artifacts usually get bundles in fat jars (namely {{flink-libraries}}, {{flink-connectors}}, and {{flink-metrics}} should override the {{slf4j}} and {{jsr305}} dependencies as provided.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)