Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F04E2200BFB for ; Tue, 6 Dec 2016 15:32:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EF34A160B0C; Tue, 6 Dec 2016 14:32:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 267EE160B31 for ; Tue, 6 Dec 2016 15:32:00 +0100 (CET) Received: (qmail 62860 invoked by uid 500); 6 Dec 2016 14:32:00 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 62259 invoked by uid 99); 6 Dec 2016 14:31:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 14:31:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A3F7D2C03F4 for ; Tue, 6 Dec 2016 14:31:59 +0000 (UTC) Date: Tue, 6 Dec 2016 14:31:59 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-5041) Implement savepoint backwards compatibility 1.1 -> 1.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 06 Dec 2016 14:32:02 -0000 [ https://issues.apache.org/jira/browse/FLINK-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725662#comment-15725662 ] ASF GitHub Bot commented on FLINK-5041: --------------------------------------- Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2781#discussion_r91083191 --- Diff: flink-runtime/src/main/java/org/apache/flink/migration/runtime/checkpoint/KeyGroupState.java --- @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.migration.runtime.checkpoint; + +import org.apache.flink.migration.runtime.state.StateHandle; +import org.apache.flink.migration.util.SerializedValue; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Serializable; + +/** + * Simple container class which contains the serialized state handle for a key group. + * + * The key group state handle is kept in serialized form because it can contain user code classes + * which might not be available on the JobManager. + */ +@Deprecated +public class KeyGroupState implements Serializable { + private static final long serialVersionUID = -5926696455438467634L; + + private static final Logger LOG = LoggerFactory.getLogger(KeyGroupState.class); + + private final SerializedValue> keyGroupState; + + private final long stateSize; + + private final long duration; + + public KeyGroupState(SerializedValue> keyGroupState, long stateSize, long duration) { + this.keyGroupState = keyGroupState; + + this.stateSize = stateSize; + + this.duration = duration; + } + + public SerializedValue> getKeyGroupState() { + return keyGroupState; + } + + public long getDuration() { + return duration; + } + + public long getStateSize() { + return stateSize; + } + + public void discard(ClassLoader classLoader) throws Exception { + keyGroupState.deserializeValue(classLoader).discardState(); --- End diff -- Let's "deactivate" this method by throwing an `UnsupportedOperationException`. > Implement savepoint backwards compatibility 1.1 -> 1.2 > ------------------------------------------------------ > > Key: FLINK-5041 > URL: https://issues.apache.org/jira/browse/FLINK-5041 > Project: Flink > Issue Type: New Feature > Components: State Backends, Checkpointing > Affects Versions: 1.2.0 > Reporter: Stefan Richter > Assignee: Stefan Richter > > This issue tracks the implementation of backwards compatibility between Flink 1.1 and 1.2 releases. > This task subsumes: > - Converting old savepoints to new savepoints, including a conversion of state handles to their new replacement. > - Converting keyed state from old backend implementations to their new counterparts. > - Converting operator and function state for all changed operators. -- This message was sent by Atlassian JIRA (v6.3.4#6332)