Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 170E4200C03 for ; Fri, 16 Dec 2016 13:37:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 15BF8160AF6; Fri, 16 Dec 2016 12:37:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 506B7160B24 for ; Fri, 16 Dec 2016 13:36:59 +0100 (CET) Received: (qmail 24209 invoked by uid 500); 16 Dec 2016 12:36:58 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 24181 invoked by uid 99); 16 Dec 2016 12:36:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Dec 2016 12:36:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 66A2F2C03E0 for ; Fri, 16 Dec 2016 12:36:58 +0000 (UTC) Date: Fri, 16 Dec 2016 12:36:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-4255) Unstable test WebRuntimeMonitorITCase.testNoEscape MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 16 Dec 2016 12:37:00 -0000 [ https://issues.apache.org/jira/browse/FLINK-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754309#comment-15754309 ] ASF GitHub Bot commented on FLINK-4255: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3019#discussion_r92804170 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitorITCase.java --- @@ -262,8 +247,8 @@ public void testRedirectToLeader() throws Exception { response = followingClient.getNextResponse(deadline.timeLeft()); assertEquals(HttpResponseStatus.OK, response.getStatus()); assertEquals(response.getType(), MimeTypes.getMimeTypeForExtension("json")); - assertTrue(response.getContent().contains("\"taskmanagers\":1") || - response.getContent().contains("\"taskmanagers\":0")); + assertThat(response.getContent(), either(containsString("\"taskmanagers\":1")) --- End diff -- Why did you change this line? (Note that this applies to all lines that replace assertTrue with assertThat, contains with containsString and | with or.) > Unstable test WebRuntimeMonitorITCase.testNoEscape > -------------------------------------------------- > > Key: FLINK-4255 > URL: https://issues.apache.org/jira/browse/FLINK-4255 > Project: Flink > Issue Type: Bug > Reporter: Kostas Kloudas > Assignee: Boris Osipov > Labels: test-stability > > An instance of the problem can be found here: > https://s3.amazonaws.com/archive.travis-ci.org/jobs/146615994/log.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332)