Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 1 Dec 2016 18:16:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12965017.1462379957000.414843.1480616218406@Atlassian.JIRA>
In-Reply-To: <JIRA.12965017.1462379957000@Atlassian.JIRA>
References: <JIRA.12965017.1462379957000@Atlassian.JIRA> <JIRA.12965017.1462379957407@arcas>
Subject: [jira] [Commented] (FLINK-3871) Add Kafka TableSource with Avro
 serialization
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 01 Dec 2016 18:17:00 -0000


    [ https://issues.apache.org/jira/browse/FLINK-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712647#comment-15712647 ] 

ASF GitHub Bot commented on FLINK-3871:
---------------------------------------

Github user mushketyk commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2762#discussion_r90504878
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSource.java ---
    @@ -0,0 +1,84 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.kafka;
    +
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.table.sources.StreamTableSource;
    +import org.apache.flink.streaming.connectors.kafka.internals.TypeUtil;
    +import org.apache.flink.streaming.util.serialization.AvroRowDeserializationSchema;
    +import org.apache.flink.streaming.util.serialization.DeserializationSchema;
    +
    +import java.util.Properties;
    +
    +/**
    + * A version-agnostic Kafka Avro {@link StreamTableSource}.
    + *
    + * <p>The version-specific Kafka consumers need to extend this class and
    + * override {@link #getKafkaConsumer(String, Properties, DeserializationSchema)}}.
    + *
    + * <p>The field names are used to parse the Avro file and so are the types.
    + */
    +public abstract class KafkaAvroTableSource extends KafkaTableSource {
    +
    +	/**
    +	 * Creates a generic Kafka Avro {@link StreamTableSource}.
    +	 *
    +	 * @param topic      Kafka topic to consume.
    +	 * @param properties Properties for the Kafka consumer.
    +	 * @param fieldNames Row field names.
    +	 * @param fieldTypes Row field types.
    +	 */
    +	KafkaAvroTableSource(
    +		String topic,
    +		Properties properties,
    +		String[] fieldNames,
    +		Class<?>[] fieldTypes) {
    +
    +		super(topic, properties, createDeserializationSchema(fieldTypes), fieldNames, fieldTypes);
    +	}
    +
    +	/**
    +	 * Creates a generic Kafka Avro {@link StreamTableSource}.
    +	 *
    +	 * @param topic      Kafka topic to consume.
    +	 * @param properties Properties for the Kafka consumer.
    +	 * @param fieldNames Row field names.
    +	 * @param fieldTypes Row field types.
    +	 */
    +	KafkaAvroTableSource(
    +		String topic,
    +		Properties properties,
    +		String[] fieldNames,
    +		TypeInformation<?>[] fieldTypes) {
    +
    +		super(topic, properties, createDeserializationSchema(fieldTypes), fieldNames, fieldTypes);
    +	}
    +
    +	private static AvroRowDeserializationSchema createDeserializationSchema(
    +		TypeInformation<?>[] fieldTypes) {
    +
    +		return new AvroRowDeserializationSchema(new String[]{"f1", "f2", "f3"}, fieldTypes);
    +	}
    +
    +	private static AvroRowDeserializationSchema createDeserializationSchema(
    +		Class<?>[] fieldTypes) {
    +
    +		return new AvroRowDeserializationSchema(new String[]{"f1", "f2", "f3"}, TypeUtil.toTypeInfo(fieldTypes));
    --- End diff --
    
    Ditto. 


> Add Kafka TableSource with Avro serialization
> ---------------------------------------------
>
>                 Key: FLINK-3871
>                 URL: https://issues.apache.org/jira/browse/FLINK-3871
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>
> Add a Kafka TableSource which supports Avro serialized data.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)