Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: ex00 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-3033-flink@git.apache.org>
In-Reply-To: <git-pr-3033-flink@git.apache.org>
Subject: [GitHub] flink pull request #3033: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...
Content-Type: text/plain
Message-Id: <20161222094638.1D6EFDFBE9@git1-us-west.apache.org>
Date: Thu, 22 Dec 2016 09:46:38 +0000 (UTC)
archived-at: Thu, 22 Dec 2016 09:46:41 -0000

Github user ex00 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3033#discussion_r93592588
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetJoinRule.scala ---
    @@ -40,10 +41,17 @@ class DataSetJoinRule
         val joinInfo = join.analyzeCondition
     
         // joins require an equi-condition or a conjunctive predicate with at least one equi-condition
    -    !joinInfo.pairs().isEmpty
    +    !joinInfo.pairs().isEmpty || isOuterJoin(join)
    --- End diff --
    
    Yes, I can.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---