Return-Path: <issues-return-83196-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id C9D53200BE5
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  9 Dec 2016 15:52:54 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id C8A81160B1D; Fri,  9 Dec 2016 14:52:54 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 278D1160B2A
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  9 Dec 2016 15:52:54 +0100 (CET)
Received: (qmail 93500 invoked by uid 500); 9 Dec 2016 14:52:53 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 93484 invoked by uid 99); 9 Dec 2016 14:52:53 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2016 14:52:53 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AA8161A9D28
	for <issues@flink.apache.org>; Fri,  9 Dec 2016 14:52:52 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -7.019
X-Spam-Level: 
X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-2.999] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id g99GYglMYNYb for <issues@flink.apache.org>;
	Fri,  9 Dec 2016 14:52:51 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id C9E7D5F571
	for <issues@flink.incubator.apache.org>; Fri,  9 Dec 2016 14:52:50 +0000 (UTC)
Received: (qmail 93198 invoked by uid 99); 9 Dec 2016 14:52:50 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2016 14:52:50 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id EAEC0EEE2F; Fri,  9 Dec 2016 14:52:49 +0000 (UTC)
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2939-flink@git.apache.org>
In-Reply-To: <git-pr-2939-flink@git.apache.org>
Subject: [GitHub] flink pull request #2939: [FLINK-5113] Ports all functions in the tests to t...
Content-Type: text/plain
Message-Id: <20161209145249.EAEC0EEE2F@git1-us-west.apache.org>
Date: Fri,  9 Dec 2016 14:52:49 +0000 (UTC)
archived-at: Fri, 09 Dec 2016 14:52:55 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2939#discussion_r91724133
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/classloading/jar/CheckpointedStreamingProgram.java ---
    @@ -72,34 +74,27 @@ public void run(SourceContext<String> ctx) throws Exception {
     		public void cancel() {
     			running = false;
     		}
    -
    -		@Override
    -		public Integer snapshotState(long checkpointId, long checkpointTimestamp) throws Exception {
    -			return null;
    -		}
    -
    -		@Override
    -		public void restoreState(Integer state) {
    -
    -		}
     	}
     
    -	public static class StatefulMapper implements MapFunction<String, String>, Checkpointed<StatefulMapper>, CheckpointListener {
    +	public static class StatefulMapper implements MapFunction<String, String>, ListCheckpointed<StatefulMapper>, CheckpointListener {
     
     		private String someState;
     		private boolean atLeastOneSnapshotComplete = false;
     		private boolean restored = false;
     
     		@Override
    -		public StatefulMapper snapshotState(long checkpointId, long checkpointTimestamp) throws Exception {
    -			return this;
    +		public List<StatefulMapper> snapshotState(long checkpointId, long timestamp) throws Exception {
    +			return Collections.singletonList(this);
     		}
     
     		@Override
    -		public void restoreState(StatefulMapper state) {
    -			restored = true;
    -			this.someState = state.someState;
    -			this.atLeastOneSnapshotComplete = state.atLeastOneSnapshotComplete;
    +		public void restoreState(List<StatefulMapper> state) throws Exception {
    +			if (!state.isEmpty()) {
    --- End diff --
    
    If the state is empty we should fail immediately; currently (I think) this would cause us to fail with the RuntimeException saying "Intended failure, to trigger restore", which is a bit inaccurate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---