Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2810-flink@git.apache.org>
In-Reply-To: <git-pr-2810-flink@git.apache.org>
Subject: [GitHub] flink pull request #2810: [FLINK-3848] Add ProjectableTableSource interface ...
Content-Type: text/plain
Message-Id: <20161206151146.57942DFFAB@git1-us-west.apache.org>
Date: Tue,  6 Dec 2016 15:11:46 +0000 (UTC)
archived-at: Tue, 06 Dec 2016 15:14:04 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2810#discussion_r91054316
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetScan.scala ---
    @@ -42,6 +43,11 @@ class DataSetScan(
     
       override def deriveRowType() = rowRelDataType
     
    +  override def computeSelfCost(planner: RelOptPlanner, metadata: RelMetadataQuery): RelOptCost = {
    +    val rowCnt = metadata.getRowCount(this)
    +    planner.getCostFactory.makeCost(rowCnt, rowCnt + 1, 0)
    --- End diff --
    
    Why `rowCnt + 1`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---