Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: uce <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2930-flink@git.apache.org>
In-Reply-To: <git-pr-2930-flink@git.apache.org>
Subject: [GitHub] flink pull request #2930: [FLINK-5246] Don't discard checkpoint messages if ...
Content-Type: text/plain
Message-Id: <20161204120018.5C6DBDFCF9@git1-us-west.apache.org>
Date: Sun,  4 Dec 2016 12:00:18 +0000 (UTC)
archived-at: Sun, 04 Dec 2016 12:00:23 -0000

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2930#discussion_r90775412
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
    @@ -1376,6 +1376,24 @@ class JobManager(
                         // addressed to the periodic checkpoint coordinator.
                         log.info("Received message for non-existing checkpoint " +
                           ackMessage.getCheckpointId)
    +
    +                    val classLoader = Option(libraryCacheManager.getClassLoader(jid)) match {
    +                      case Some(userCodeClassLoader) => userCodeClassLoader
    +                      case None => getClass.getClassLoader
    +                    }
    +
    +                    future {
    +                      Option(ackMessage.getState()) match {
    --- End diff --
    
    Should we check the option before submitting the future and only do it if it's non empty?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---