flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5385) Add a help function to create Row
Date Thu, 22 Dec 2016 06:26:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769222#comment-15769222
] 

ASF GitHub Bot commented on FLINK-5385:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/3038

    [FLINK-5385] [core] Add a help function to create Row

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    Currently, it is trivial to create a Row, for example:
    
    ```java
    Row row = new Row(3);
    row.setField(0, "hello");
    row.setField(1, true);
    row.setField(2, 1L);
    ```
    
    This PR introduces an `of` help method to create a Row, such as:
    
    ```java
    Row row = Row.of("hello", true, 1L);
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink rowof-FLINK-5385

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3038.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3038
    
----
commit 8213c4722b83e5e6573cb7d84940a09d0fe1211f
Author: Jark Wu <wuchong.wc@alibaba-inc.com>
Date:   2016-12-22T06:23:57Z

    [FLINK-5385] [core] Add a help function to create Row

----


> Add a help function to create Row
> ---------------------------------
>
>                 Key: FLINK-5385
>                 URL: https://issues.apache.org/jira/browse/FLINK-5385
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>
> Currently, it is trivial to create a Row, for example:
> {code:java}
> Row row = new Row(3);
> row.setField(0, "hello");
> row.setField(1, true);
> row.setField(2, 1L);
> {code}
> It would be nice to have a help method {{of}} to create a Row, such as:
> {code:java}
> Row row = Row.of("hello", true, 1L);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message