flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5362) Implement methods to access BipartiteGraph properties
Date Sun, 18 Dec 2016 09:05:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15758511#comment-15758511
] 

ASF GitHub Bot commented on FLINK-5362:
---------------------------------------

GitHub user mushketyk opened a pull request:

    https://github.com/apache/flink/pull/3024

    [FLINK-5362] Implement methods to access BipartiteGraph properties

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    
    I've implemented methods to access `BipartiteGraph` properties similarly to methods that
we have in `Graph` class.
    
    I am not sure about the method name `getTuples` that I added to the class. `Graph` class
has a similar method `getTriples`, but in case of a bipartite graph we do not return triplets
(tuples with three values). Should I keep names consistent?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mushketyk/flink bipartite-graph-properties

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3024.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3024
    
----
commit cab888152308d9fc6b10516ee03a17d1fce731b7
Author: Ivan Mushketyk <ivan.mushketik@gmail.com>
Date:   2016-12-18T09:02:28Z

    [FLINK-5362] Implement methods to access BipartiteGraph properties

----


> Implement methods to access BipartiteGraph properties
> -----------------------------------------------------
>
>                 Key: FLINK-5362
>                 URL: https://issues.apache.org/jira/browse/FLINK-5362
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ivan Mushketyk
>            Assignee: Ivan Mushketyk
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message