flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5304) Change method name from crossApply to join in Table API
Date Fri, 09 Dec 2016 13:55:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735383#comment-15735383
] 

ASF GitHub Bot commented on FLINK-5304:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2978#discussion_r91717856
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/FlinkCorrelate.scala
---
    @@ -63,17 +63,17 @@ trait FlinkCorrelate {
            """.stripMargin
     
         if (joinType == SemiJoinType.INNER) {
    -      // cross apply
    +      // cross join
    --- End diff --
    
    `cross join` -> `inner join`


> Change method name from crossApply to join in Table API
> -------------------------------------------------------
>
>                 Key: FLINK-5304
>                 URL: https://issues.apache.org/jira/browse/FLINK-5304
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>
> Currently, the UDTF in Table API is used with {{crossApply}}, but is used with JOIN in
SQL. UDTF is something similar to Table, so it make sense to use {{.join("udtf(c) as (s)")}}
in Table API too, and join is more familiar to users than {{crossApply}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message