flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5280) Extend TableSource to support nested data
Date Fri, 23 Dec 2016 13:10:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772868#comment-15772868
] 

ASF GitHub Bot commented on FLINK-5280:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3039#discussion_r93763884
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
    @@ -111,24 +112,17 @@
     		return kafkaSource;
     	}
     
    -	@Override
    -	public int getNumberOfFields() {
    -		return fieldNames.length;
    -	}
    -
    -	@Override
     	public String[] getFieldsNames() {
    -		return fieldNames;
    +		return TableSource$class.getFieldsNames(this);
    --- End diff --
    
    What about to make `TableSource` abstract class? So that it can fit in with Java and Scala
without involving something hack.
    
    In this way, the `StreamTableSource` and `BatchTableSource` should be abstract class too.


> Extend TableSource to support nested data
> -----------------------------------------
>
>                 Key: FLINK-5280
>                 URL: https://issues.apache.org/jira/browse/FLINK-5280
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Ivan Mushketyk
>
> The {{TableSource}} interface does currently only support the definition of flat rows.

> However, there are several storage formats for nested data that should be supported such
as Avro, Json, Parquet, and Orc. The Table API and SQL can also natively handle nested rows.
> The {{TableSource}} interface and the code to register table sources in Calcite's schema
need to be extended to support nested data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message