flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5280) Extend TableSource to support nested data
Date Fri, 23 Dec 2016 12:23:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772769#comment-15772769
] 

ASF GitHub Bot commented on FLINK-5280:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3039#discussion_r93759055
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/TableSourceTable.scala
---
    @@ -25,6 +25,6 @@ import org.apache.flink.types.Row
     /** Table which defines an external table via a [[TableSource]] */
     class TableSourceTable(val tableSource: TableSource[_])
       extends FlinkTable[Row](
    --- End diff --
    
    I think it's not necessary to declare the return type is `Row`. `TableSource` could return
Pojo in the future.
    
    So it should be declared like `DataSetTable` and `DataStreamTable`, such as: 
    
    ```scala
    class TableSourceTable[T](val tableSource: TableSource[T])
      extends FlinkTable[T](
    ```


> Extend TableSource to support nested data
> -----------------------------------------
>
>                 Key: FLINK-5280
>                 URL: https://issues.apache.org/jira/browse/FLINK-5280
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Ivan Mushketyk
>
> The {{TableSource}} interface does currently only support the definition of flat rows.

> However, there are several storage formats for nested data that should be supported such
as Avro, Json, Parquet, and Orc. The Table API and SQL can also natively handle nested rows.
> The {{TableSource}} interface and the code to register table sources in Calcite's schema
need to be extended to support nested data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message