flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Shoshin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5255) Improve single row check in DataSetSingleRowJoinRule
Date Wed, 14 Dec 2016 10:20:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747924#comment-15747924

Alexander Shoshin commented on FLINK-5255:

Looks cool!
I'll add an empty input support and make a PR

> Improve single row check in DataSetSingleRowJoinRule
> ----------------------------------------------------
>                 Key: FLINK-5255
>                 URL: https://issues.apache.org/jira/browse/FLINK-5255
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Alexander Shoshin
> {{DataSetSingleRowJoinRule}} checks converts an arbitrary inner join (cross, theta, equi)
where one input has exactly one row into a broadcast-map join.
> Currently, the condition to check for the single row is that the input of the join must
be a global aggregation. The check fails if the input is a {{LogicalCalc}} followed by {{LogicalAggregate}}.
> Hence, the following query cannot be executed:
> {code}
> SELECT absum, x.a
> FROM x, (SELECT a.sum + b.sum AS absum FROM y)
> {code}
> The single row check should be extended to accept a {{LogicalCalc}} that has no condition
{{(RexProgram.getCondition() == null)}}.

This message was sent by Atlassian JIRA

View raw message