flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5211) Include an example configuration for all reporters
Date Thu, 08 Dec 2016 22:56:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733650#comment-15733650
] 

ASF GitHub Bot commented on FLINK-5211:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2972#discussion_r91626592
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -335,6 +345,21 @@ Parameters:
     - `ttl` - time-to-live for transmitted UDP packets
     - `addressingMode` - UDP addressing mode to use (UNICAST/MULTICAST)
     
    +Example configuration:
    +
    +{% highlight yaml %}
    +
    +metrics.reporters: gang
    --- End diff --
    
    I think that's very easy to understand when reading the first, but this is definitely
good enough! Feel free to merge as is, but can you double check that the examples are actually
correct (no typos, etc.) and consistent with the other parts of the documentation.


> Include an example configuration for all reporters
> --------------------------------------------------
>
>                 Key: FLINK-5211
>                 URL: https://issues.apache.org/jira/browse/FLINK-5211
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation, Metrics
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.2.0
>
>
> We should extend the reporter documentation to include an example configuration for every
reporter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message