flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5179) MetricRegistry life-cycle issues with HA
Date Fri, 02 Dec 2016 14:46:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715309#comment-15715309
] 

ASF GitHub Bot commented on FLINK-5179:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2886#discussion_r90653350
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
    @@ -1046,11 +1046,10 @@ class TaskManager(
           network.getKvStateRegistry.unregisterListener()
         }
         
    -    // failsafe shutdown of the metrics registry
         try {
    -      metricsRegistry.shutdown()
    +      taskManagerMetricGroup.close()
    --- End diff --
    
    That was already the case before this PR.


> MetricRegistry life-cycle issues with HA
> ----------------------------------------
>
>                 Key: FLINK-5179
>                 URL: https://issues.apache.org/jira/browse/FLINK-5179
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.3
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.2.0, 1.1.4
>
>
> The TaskManager's MetricRegistry is started when the TaskManager is created, and shutdown
in the TaskManager's postStop method.
> However, the registry is also shutdown within the TaskManager's disassociateFromJobManager
method; however it is not restarted when the connection is re-established.
> Effectively this means that a TaskManager that ever reconnected to a JobManager will
not report any metrics, since the reporters are shutdown as well. Metrics will neither be
sent to the WebInterface anymore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message