flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5113) Make all Testing Functions implement CheckpointedFunction Interface.
Date Fri, 09 Dec 2016 14:52:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735507#comment-15735507
] 

ASF GitHub Bot commented on FLINK-5113:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2939#discussion_r91720690
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/AbstractEventTimeWindowCheckpointingITCase.java
---
    @@ -566,23 +568,25 @@ public void notifyCheckpointComplete(long checkpointId) {
     			numSuccessfulCheckpoints++;
     		}
     
    -		@Override
    -		public Integer snapshotState(long checkpointId, long checkpointTimestamp) {
    -			return numElementsEmitted;
    +		public static void reset() {
    --- End diff --
    
    please move this method to the bottom of the class again.


> Make all Testing Functions implement CheckpointedFunction Interface.
> --------------------------------------------------------------------
>
>                 Key: FLINK-5113
>                 URL: https://issues.apache.org/jira/browse/FLINK-5113
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.2.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.2.0
>
>
> Currently stateful functions implement the (old) Checkpointed interface.
> This is issue aims at porting all these function to the new CheckpointedFunction interface,
so that they can leverage the new 
> capabilities by it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message