flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5091) Formalize the AppMaster environment for docker compability
Date Thu, 01 Dec 2016 10:55:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711644#comment-15711644
] 

ASF GitHub Bot commented on FLINK-5091:
---------------------------------------

Github user Makman2 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2915#discussion_r90423889
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -1372,6 +1381,12 @@
     	/** The environment variable name which contains the location of the lib folder */
     	public static final String ENV_FLINK_LIB_DIR = "FLINK_LIB_DIR";
     
    +	/** The environment variable name which contains the location of the bin directory */
    +	public static final String ENV_FLINK_BIN_DIR = "FLINK_BIN_DIR";
    +
    +	/** The environment variable name which contains the Flink installation root directory
*/
    +	public static final String ENV_FLINK_HOME_DIR = "FLINK_HOME";
    +
    --- End diff --
    
    you sure these should be config values? What if someone wants to set these to `$MESOS_SANDBOX`,
then we need to rely on shell expansion on an already started container^^ (Not sure this is
a usecase)


> Formalize the AppMaster environment for docker compability
> ----------------------------------------------------------
>
>                 Key: FLINK-5091
>                 URL: https://issues.apache.org/jira/browse/FLINK-5091
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management, Mesos
>            Reporter: Eron Wright 
>            Assignee: Eron Wright 
>             Fix For: 1.2.0
>
>
> For scenarios where the AppMaster is launched from a docker image, it would be ideal
to use the installed Flink rather than rely on a special file layout in the sandbox directory.
> This is related to DCOS integration, which (in 1.2) will launch the AppMaster via Marathon
(as a top-level DCOS service).  The existing code assumed that only the dispatcher (coming
in 1.3) would launch the AppMaster.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message