flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5041) Implement savepoint backwards compatibility 1.1 -> 1.2
Date Tue, 06 Dec 2016 14:31:59 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725656#comment-15725656
] 

ASF GitHub Bot commented on FLINK-5041:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2781#discussion_r91087691
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -1317,9 +1320,13 @@ class JobManager(
                     log.info(s"Starting job from savepoint '$savepointPath'" +
                       (if (allowNonRestored) " (allowing non restored state)" else "") +
".")
     
    -                // load the savepoint as a checkpoint into the system
    -                val savepoint: CompletedCheckpoint = SavepointLoader.loadAndValidateSavepoint(
    -                  jobId, executionGraph.getAllVertices, savepointPath, allowNonRestored)
    +                  // load the savepoint as a checkpoint into the system
    +                  val savepoint: CompletedCheckpoint = SavepointLoader.loadAndValidateSavepoint(
    +                    jobId,
    +                    executionGraph.getAllVertices,
    +                    savepointPath,
    +                    userCodeLoader,
    --- End diff --
    
    Minor comment: I think you can grab the user code ClassLoader form the ExecutionGraph
(that allows you to keep the class loader variable final and in the narrower scope)


> Implement savepoint backwards compatibility 1.1 -> 1.2
> ------------------------------------------------------
>
>                 Key: FLINK-5041
>                 URL: https://issues.apache.org/jira/browse/FLINK-5041
>             Project: Flink
>          Issue Type: New Feature
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.2.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>
> This issue tracks the implementation of backwards compatibility between Flink 1.1 and
1.2 releases.
> This task subsumes:
> - Converting old savepoints to new savepoints, including a conversion of state handles
to their new replacement.
> - Converting keyed state from old backend implementations to their new counterparts.
> - Converting operator and function state for all changed operators.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message