flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tzu-Li (Gordon) Tai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4905) Kafka test instability IllegalStateException: Client is not started
Date Wed, 07 Dec 2016 08:57:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728171#comment-15728171

Tzu-Li (Gordon) Tai commented on FLINK-4905:

Hi [~Andrew Efimov],

Sorry for the very late response, I've been quite busy recently.
Thanks a lot for looking into this in so much detail!

For the two approaches you mentioned, the second one seems more reasonable to me at a first
look. I would also recommend that we change the `ZookeeperOffsetHandler`'s own logic to be
fail-proof to these concurrent accesses.
>From what I understand of your approaches, we're still relying on the fetcher's logic
to call `ZookeeperOffsetHandler` safely. I think it would be a good design that the `ZookeeperOffsetHandler`
is also self-contained, and don't need to rely on the callers' behaviour at all.

I'm not really sure if my comment makes sense, since I haven't looked too much into this yet.
I think it would be great if you can go ahead and open the PR, and we can further look at
it from there :) I'll be happy to shepherd your contribution!

> Kafka test instability IllegalStateException: Client is not started
> -------------------------------------------------------------------
>                 Key: FLINK-4905
>                 URL: https://issues.apache.org/jira/browse/FLINK-4905
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>            Reporter: Robert Metzger
>            Assignee: Andrew Efimov
>              Labels: test-stability
>         Attachments: Kafka08Fetcher.png
> The following travis build (https://s3.amazonaws.com/archive.travis-ci.org/jobs/170365439/log.txt)
 failed because of this error
> {code}
> 08:17:11,239 INFO  org.apache.flink.runtime.jobmanager.JobManager                - Status
of job 33ebdc0e7c91be186d80658ce3d17069 (Read some records to commit offsets to Kafka) changed
> java.lang.RuntimeException: Error while confirming checkpoint
> 	at org.apache.flink.runtime.taskmanager.Task$4.run(Task.java:1040)
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> 	at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.IllegalStateException: Client is not started
> 	at org.apache.flink.shaded.com.google.common.base.Preconditions.checkState(Preconditions.java:173)
> 	at org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:113)
> 	at org.apache.curator.utils.EnsurePath$InitialHelper$1.call(EnsurePath.java:148)
> 	at org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:107)
> 	at org.apache.curator.utils.EnsurePath$InitialHelper.ensure(EnsurePath.java:141)
> 	at org.apache.curator.utils.EnsurePath.ensure(EnsurePath.java:99)
> 	at org.apache.flink.streaming.connectors.kafka.internals.ZookeeperOffsetHandler.setOffsetInZooKeeper(ZookeeperOffsetHandler.java:133)
> 	at org.apache.flink.streaming.connectors.kafka.internals.ZookeeperOffsetHandler.prepareAndCommitOffsets(ZookeeperOffsetHandler.java:93)
> 	at org.apache.flink.streaming.connectors.kafka.internals.Kafka08Fetcher.commitInternalOffsetsToKafka(Kafka08Fetcher.java:341)
> 	at org.apache.flink.streaming.connectors.kafka.FlinkKafkaConsumerBase.notifyCheckpointComplete(FlinkKafkaConsumerBase.java:421)
> 	at org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.notifyOfCompletedCheckpoint(AbstractUdfStreamOperator.java:229)
> 	at org.apache.flink.streaming.runtime.tasks.StreamTask.notifyCheckpointComplete(StreamTask.java:571)
> 	at org.apache.flink.runtime.taskmanager.Task$4.run(Task.java:1035)
> 	... 5 more
> 08:17:11,241 INFO  org.apache.flink.runtime.taskmanager.Task                     - Attempting
to cancel task Source: Custom Source -> Map -> Map -> Sink: Unnamed (1/3)
> {code}

This message was sent by Atlassian JIRA

View raw message