flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4870) ContinuousFileMonitoringFunction does not properly handle absolut Windows paths
Date Wed, 14 Dec 2016 11:23:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748078#comment-15748078
] 

ASF GitHub Bot commented on FLINK-4870:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2887#discussion_r92373183
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/FileSystemBlobStore.java
---
    @@ -81,7 +81,7 @@ public void put(File localFile, JobID jobId, String key) throws Exception
{
     	}
     
     	private void put(File fromFile, String toBlobPath) throws Exception {
    -		try (OutputStream os = FileSystem.get(new URI(toBlobPath))
    +		try (OutputStream os = FileSystem.get(new Path(toBlobPath).toUri())
    --- End diff --
    
    Would be good to avoid creating the Path twice and do `Path p = new Path(toBlobPath);
p.getFileSystem().create(p, true)`


> ContinuousFileMonitoringFunction does not properly handle absolut Windows paths
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-4870
>                 URL: https://issues.apache.org/jira/browse/FLINK-4870
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 1.1.2
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> The ContinuousFileMonitoringFunction fails for absolute windows paths without  a dedicated
scheme (e.g "C:\\tmp\\test.csv"), since the String path is directly fed into the URI constructor
(which doesn't handle it properly) instead of first creating a flink Path and converting that
into an URI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message