flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4255) Unstable test WebRuntimeMonitorITCase.testNoEscape
Date Fri, 16 Dec 2016 12:36:58 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754309#comment-15754309
] 

ASF GitHub Bot commented on FLINK-4255:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3019#discussion_r92804170
  
    --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitorITCase.java
---
    @@ -262,8 +247,8 @@ public void testRedirectToLeader() throws Exception {
     				response = followingClient.getNextResponse(deadline.timeLeft());
     				assertEquals(HttpResponseStatus.OK, response.getStatus());
     				assertEquals(response.getType(), MimeTypes.getMimeTypeForExtension("json"));
    -				assertTrue(response.getContent().contains("\"taskmanagers\":1") ||
    -						response.getContent().contains("\"taskmanagers\":0"));
    +				assertThat(response.getContent(), either(containsString("\"taskmanagers\":1"))
    --- End diff --
    
    Why did you change this line? (Note that this applies to all lines that replace assertTrue
with assertThat, contains with containsString and | with or.)


> Unstable test WebRuntimeMonitorITCase.testNoEscape
> --------------------------------------------------
>
>                 Key: FLINK-4255
>                 URL: https://issues.apache.org/jira/browse/FLINK-4255
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Kostas Kloudas
>            Assignee: Boris Osipov
>              Labels: test-stability
>
> An instance of the problem can be found here:
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/146615994/log.txt



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message