flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2723: [FLINK-3617] Fix for OptionSerializer.
Date Thu, 15 Dec 2016 11:13:56 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestBase.java
    @@ -409,9 +402,26 @@ else if (should instanceof Throwable) {
     			assertEquals(((Throwable)should).getMessage(), ((Throwable)is).getMessage());
     		else {
    +			// if toString() was overridden we must check it
    +			if (!should.toString().equals(should.getClass().getName() +
    +										  "@" + Integer.toHexString(should.hashCode()))) {
    --- End diff --
    This can be more robustly done by looking up the 'toString()' method and seeing if the
defining class was `Object`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message