flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3003: [FLINK-5188] Create analog of RowCsvInputFormat in...
Date Wed, 14 Dec 2016 11:35:43 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3003#discussion_r92375174
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/BatchTableEnvironment.scala
---
    @@ -168,8 +168,10 @@ abstract class BatchTableEnvironment(
       private[flink] def explain(table: Table, extended: Boolean): String = {
         val ast = table.getRelNode
         val optimizedPlan = optimize(ast)
    -    val dataSet = translate[Row](optimizedPlan)(TypeExtractor.createTypeInfo(classOf[Row]))
    -    dataSet.output(new DiscardingOutputFormat[Row])
    +    val dataSet = translate[org.apache.flink.types.Row](optimizedPlan) (
    --- End diff --
    
    OK, I see why you did it this way. I'll move this PR behind #3004.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message