flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink issue #2982: [FLINK-4460] Side Outputs in Flink
Date Tue, 13 Dec 2016 14:32:38 GMT
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2982
  
    @chenqin I had a quick look at the implementation and it looks quite good. I'll look at
it in more detail once the 1.2 release is out and then I'll also have more thorough comments.
    
    These are some quick comments off the top of my head:
     - I think we can extend `Collector` with a `collect(OutputTag, T)` method. Then we wouldn't
need the extra `RichCollector` and `CollectorWrapper` to work around that.
     - For `WindowedStream` I would like to have something like this:
    ```
    OutputTag<T> lateElementsOutput = ...;
    DataStream<T> input = ...
    SingleOutputStreamOperator<O> windowed = input
      .keyBy(...)
      .window(...)
      .apply(Function, lateElementsOutput);
    
    DataStream<T> lateElements = windowed.getSideOutput(lateElementsOutput);
    ```
    or maube something else if we find a better Idea. With the `WindowedStream.tooLateElements()`
this would instantiate an extra `WindowOperator` just for getting late elements while another
window operator would be responsible for processing the actual elements. That seems wasteful.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message