flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2939: [FLINK-5113] Ports all functions in the tests to t...
Date Fri, 09 Dec 2016 14:52:49 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2939#discussion_r91721756
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamCheckpointNotifierITCase.java
---
    @@ -447,5 +434,23 @@ public void notifyCheckpointComplete(long checkpointId) {
     				GeneratingSourceFunction.numPostFailureNotifications.incrementAndGet();
     			}
     		}
    +
    +		@Override
    +		public List<Long> snapshotState(long checkpointId, long timestamp) throws Exception
{
    +			if (!hasFailed && count >= failurePos && getRuntimeContext().getIndexOfThisSubtask()
== 0) {
    --- End diff --
    
    please move this methods up again to reduce the diff. The methods are identical apart
from the signature and return statement, the diff should reflect that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message