flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #2972: [FLINK-5211] [metrics] [docs] Include example repo...
Date Thu, 08 Dec 2016 22:56:50 GMT
Github user uce commented on a diff in the pull request:

    --- Diff: docs/monitoring/metrics.md ---
    @@ -335,6 +345,21 @@ Parameters:
     - `ttl` - time-to-live for transmitted UDP packets
     - `addressingMode` - UDP addressing mode to use (UNICAST/MULTICAST)
    +Example configuration:
    +{% highlight yaml %}
    +metrics.reporters: gang
    --- End diff --
    I think that's very easy to understand when reading the first, but this is definitely
good enough! Feel free to merge as is, but can you double check that the examples are actually
correct (no typos, etc.) and consistent with the other parts of the documentation.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message