flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...
Date Fri, 02 Dec 2016 16:00:52 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2915#discussion_r90664795
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/Krb5ConfOverlay.java
---
    @@ -0,0 +1,111 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.clusterframework.overlays;
    +
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.core.fs.Path;
    +import org.apache.flink.runtime.clusterframework.ContainerSpecification;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import javax.annotation.Nullable;
    +import java.io.File;
    +import java.io.IOException;
    +
    +
    +/**
    + * Overlays a Kerberos configuration file into a container.
    + *
    + * The following files are copied to the container:
    + *  - krb5.conf
    + *
    + * The following Java system properties are set in the container:
    + *  - java.security.krb5.conf
    + */
    +public class Krb5ConfOverlay extends AbstractContainerOverlay {
    +
    +	private static final Logger LOG = LoggerFactory.getLogger(Krb5ConfOverlay.class);
    +
    +	static final String JAVA_SECURITY_KRB5_CONF = "java.security.krb5.conf";
    +
    +	static final Path TARGET_PATH = new Path("krb5.conf");
    +	final Path krb5Conf;
    +
    +	public Krb5ConfOverlay(@Nullable File krb5Conf) {
    +		this.krb5Conf = krb5Conf != null ? new Path(krb5Conf.toURI()) : null;
    +	}
    +
    +	public Krb5ConfOverlay(@Nullable Path krb5Conf) {
    +		this.krb5Conf = krb5Conf;
    +	}
    +
    +	@Override
    +	public void configure(ContainerSpecification container) throws IOException {
    +		if(krb5Conf != null) {
    +			container.getArtifacts().add(ContainerSpecification.Artifact.newBuilder()
    +				.setSource(krb5Conf)
    +				.setDest(TARGET_PATH)
    +				.setCachable(true)
    +				.build());
    +			container.getSystemProperties().setString(JAVA_SECURITY_KRB5_CONF, TARGET_PATH.getPath());
    +		}
    +	}
    +
    +	public static Builder newBuilder() {
    +		return new Builder();
    +	}
    +
    +	/**
    +	 * A builder for the {@link Krb5ConfOverlay}.
    +	 */
    +	public static class Builder {
    +
    +		File krb5ConfPath;
    +
    +		/**
    +		 * Configures the overlay using the current environment.
    +		 *
    +		 * Locates the krb5.conf configuration file as per
    +		 * <a href="https://docs.oracle.com/javase/8/docs/technotes/guides/security/jgss/tutorials/KerberosReq.html">Java
documentation</a>.
    +		 * Note that the JRE doesn't support the KRB5_CONFIG environment variable (JDK-7045913).
    +         */
    --- End diff --
    
    indention is off here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message