flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #2871: [FLINK-5163] Ports the production functions to the...
Date Fri, 02 Dec 2016 13:43:59 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2871#discussion_r90643076
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
    @@ -104,21 +114,63 @@ public ContinuousFileMonitoringFunction(
     		);
     
     		this.format = Preconditions.checkNotNull(format, "Unspecified File Input Format.");
    -		this.path = Preconditions.checkNotNull(path, "Unspecified Path.");
    +		this.path = Preconditions.checkNotNull(format.getFilePath().toString(), "Unspecified
Path.");
     
     		this.interval = interval;
     		this.watchType = watchType;
     		this.readerParallelism = Math.max(readerParallelism, 1);
     		this.globalModificationTime = Long.MIN_VALUE;
     	}
     
    +	public long getGlobalModificationTime() {
    --- End diff --
    
    This should probably have `@VisibleForTesting`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message