flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2917: [FLINK-2821] use custom Akka build to listen on al...
Date Fri, 02 Dec 2016 10:48:49 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2917#discussion_r90621937
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -2729,11 +2727,11 @@ object JobManager {
       def getRemoteJobManagerAkkaURL(config: Configuration) : String = {
         val (protocol, hostname, port) = TaskManager.getAndCheckJobManagerAddress(config)
     
    -    var hostPort: InetSocketAddress = null
    +    var hostPort: InetSocketAddress = new InetSocketAddress(hostname, port)
    --- End diff --
    
    It is just a check to see if we expect messages from a resolvable hostname. It is not
necessary to do that but I found test cases rely on that. Also, it improves error reporting
for the user in case a non-resolvable hostname was chosen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message