flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #2916: [FLINK-4523] [kinesis] Allow Kinesis Consumer to s...
Date Thu, 01 Dec 2016 09:49:56 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2916#discussion_r90411159
  
    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
    @@ -215,4 +229,18 @@ private static void validateOptionalPositiveDoubleProperty(Properties
config, St
     			}
     		}
     	}
    +
    +	private static void validateOptionalDateProperty(Properties config, String key, String
message) {
    --- End diff --
    
    Ah, you've already checked the parsing of Date format here.
    I'd say we don't really need to do the `ParseException` handling in `ShardConsumer` then,
because that should never fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message