Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 15 Nov 2016 14:44:59 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13020130.1478877894000.281043.1479221099051@Atlassian.JIRA>
In-Reply-To: <JIRA.13020130.1478877894000@Atlassian.JIRA>
References: <JIRA.13020130.1478877894000@Atlassian.JIRA> <JIRA.13020130.1478877894226@arcas>
Subject: [jira] [Commented] (FLINK-5056) BucketingSink deletes valid data
 when checkpoint notification is slow.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 15 Nov 2016 14:45:01 -0000


    [ https://issues.apache.org/jira/browse/FLINK-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667332#comment-15667332 ] 

ASF GitHub Bot commented on FLINK-5056:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2797#discussion_r88021880
  
    --- Diff: flink-streaming-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java ---
    @@ -426,17 +424,63 @@ public void close() throws Exception {
     		}
     	}
     
    +	// TODO: 11/10/16 this should be the close() after
    +	// introducing the dispose() method in the RichFunction.
    +	// ATTENTION: it is not thoroughly tested yet.
    +	public void closeAfterDisposeIsIntroduced() throws Exception {
    --- End diff --
    
    You remove this method in a later commit, why add it in the first place?


> BucketingSink deletes valid data when checkpoint notification is slow.
> ----------------------------------------------------------------------
>
>                 Key: FLINK-5056
>                 URL: https://issues.apache.org/jira/browse/FLINK-5056
>             Project: Flink
>          Issue Type: Bug
>          Components: filesystem-connector
>    Affects Versions: 1.1.3
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.2.0
>
>
> Currently if BucketingSink receives no data after a checkpoint and then a notification about a previous checkpoint arrives, it clears its state. This can 
> lead to not committing valid data about intermediate checkpoints for whom
> a notification has not arrived yet. As a simple sequence that illustrates the 
> problem:
> -> input data 
> -> snapshot(0) 
> -> input data
> -> snapshot(1)
> -> no data
> -> notifyCheckpointComplete(0)
> the last will clear the state of the Sink without committing as final the data 
> that arrived for checkpoint 1.
>  


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)