Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 28 Nov 2016 11:26:59 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13018828.1478525095000.377033.1480332419982@Atlassian.JIRA>
In-Reply-To: <JIRA.13018828.1478525095000@Atlassian.JIRA>
References: <JIRA.13018828.1478525095000@Atlassian.JIRA> <JIRA.13018828.1478525095248@arcas>
Subject: [jira] [Commented] (FLINK-5026) Rename TimelyFlatMap to Process
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 28 Nov 2016 11:27:05 -0000


    [ https://issues.apache.org/jira/browse/FLINK-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701727#comment-15701727 ] 

ASF GitHub Bot commented on FLINK-5026:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2788#discussion_r89762073
  
    --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/ConnectedStreams.scala ---
    @@ -101,30 +101,31 @@ class ConnectedStreams[IN1, IN2](javaStream: JavaCStream[IN1, IN2]) {
       }
     
       /**
    -   * Applies the given [[TimelyCoFlatMapFunction]] on the connected input streams,
    +   * Applies the given [[CoProcessFunction]] on the connected input streams,
        * thereby creating a transformed output stream.
        *
        * The function will be called for every element in the streams and can produce
        * zero or more output. The function can also query the time and set timers. When
        * reacting to the firing of set timers the function can emit yet more elements.
        *
    -   * A [[org.apache.flink.streaming.api.functions.co.RichTimelyCoFlatMapFunction]]
    +   * A [[RichCoProcessFunction]]
        * can be used to gain access to features provided by the
        * [[org.apache.flink.api.common.functions.RichFunction]] interface.
        *
    -   * @param coFlatMapper The [[TimelyCoFlatMapFunction]] that is called for each element
    -    *                     in the stream.
    -    *
    +   * @param coProcessFunction The [[CoProcessFunction]] that is called for each element
    +    *                    in the stream.
        * @return The transformed { @link DataStream}.
    --- End diff --
    
    The transformed [[DataStream]].


> Rename TimelyFlatMap to Process
> -------------------------------
>
>                 Key: FLINK-5026
>                 URL: https://issues.apache.org/jira/browse/FLINK-5026
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>             Fix For: 1.2.0
>
>
> The method on {{KeyedDataStream}} would be called {{process()}} and the function itself would be called {{ProcessFunction}}.
> The reason for this is that {{TimelyFlatMapFunction}} is a bit of a mouthful and with the additions to the timer API and state the {{ProcessFunction}} could become the basic, low-level, user-facing API for cases where users nowadays implement their own operator.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)