Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8F3DA200BE2 for ; Wed, 30 Nov 2016 22:37:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8DE0C160B06; Wed, 30 Nov 2016 21:37:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D7AFB160B13 for ; Wed, 30 Nov 2016 22:37:00 +0100 (CET) Received: (qmail 14867 invoked by uid 500); 30 Nov 2016 21:36:59 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 14841 invoked by uid 99); 30 Nov 2016 21:36:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2016 21:36:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BF3E42C1F56 for ; Wed, 30 Nov 2016 21:36:59 +0000 (UTC) Date: Wed, 30 Nov 2016 21:36:59 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-5002) Lack of synchronization in LocalBufferPool#getNumberOfUsedBuffers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 30 Nov 2016 21:37:01 -0000 [ https://issues.apache.org/jira/browse/FLINK-5002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709854#comment-15709854 ] Ted Yu commented on FLINK-5002: ------------------------------- lgtm > Lack of synchronization in LocalBufferPool#getNumberOfUsedBuffers > ----------------------------------------------------------------- > > Key: FLINK-5002 > URL: https://issues.apache.org/jira/browse/FLINK-5002 > Project: Flink > Issue Type: Bug > Reporter: Ted Yu > Assignee: Roman Maier > Priority: Minor > Labels: easyfix, starter > > {code} > public int getNumberOfUsedBuffers() { > return numberOfRequestedMemorySegments - availableMemorySegments.size(); > } > {code} > Access to availableMemorySegments should be protected with proper synchronization as other methods do. -- This message was sent by Atlassian JIRA (v6.3.4#6332)