Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Sat, 19 Nov 2016 10:43:58 +0000 (UTC)
From: "Kostas Kloudas (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12862783.1441811645000.319356.1479552238619@Atlassian.JIRA>
In-Reply-To: <JIRA.12862783.1441811645000@Atlassian.JIRA>
References: <JIRA.12862783.1441811645000@Atlassian.JIRA> <JIRA.12862783.1441811645794@arcas>
Subject: [jira] [Commented] (FLINK-2646) Rich functions should provide a
 method "closeAfterFailure()"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 19 Nov 2016 10:44:00 -0000


    [ https://issues.apache.org/jira/browse/FLINK-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15679034#comment-15679034 ] 

Kostas Kloudas commented on FLINK-2646:
---------------------------------------

By the way the {{RichFunction}} is annotated as {{Public}} and maven complains when trying to add a new method.
What can be a valid work-around?

> Rich functions should provide a method "closeAfterFailure()"
> ------------------------------------------------------------
>
>                 Key: FLINK-2646
>                 URL: https://issues.apache.org/jira/browse/FLINK-2646
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Liang Chen
>             Fix For: 1.0.0
>
>
> Right now, the {{close()}} method of rich functions is invoked in case of proper completion, and in case of canceling in case of error (to allow for cleanup).
> In certain cases, the user function needs to know why it is closed, whether the task completed in a regular fashion, or was canceled/failed.
> I suggest to add a method {{closeAfterFailure()}} to the {{RichFunction}}. By default, this method calls {{close()}}. The runtime is the changed to call {{close()}} as part of the regular execution and {{closeAfterFailure()}} in case of an irregular exit.
> Because by default all cases call {{close()}} the change would not be API breaking.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)